wombatu-kun commented on PR #16791: URL: https://github.com/apache/iceberg/pull/16791#issuecomment-5692248031
@pvary thanks again for the review on #16790. This is the last one from that Flink allocation batch, and a much smaller change than #16790 turned out to be: the array and map writers in `FlinkParquetWriters` build their element/key/value getters once at construction instead of per row, and reuse a single iterator instance per writer. One file, no API change, CI green. The aliasing problem you caught on #16790 does not apply here. `RepeatedWriter.write()` and `RepeatedKeyValueWriter.write()` both take the iterator as a method local and drain it in a `while` loop inside the same call, never keeping a reference, and nested collections get their own writer instances, so an iterator is never re-entered. Would you have a moment to look? One correction to the description above: the backport now targets 1.20, 2.2 and 2.3, since 2.0 was removed from the repo - same set as #18058. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
