aokolnychyi commented on a change in pull request #1947:
URL: https://github.com/apache/iceberg/pull/1947#discussion_r558541114



##########
File path: 
spark3-extensions/src/main/scala/org/apache/iceberg/spark/extensions/IcebergSparkSessionExtensions.scala
##########
@@ -43,6 +43,7 @@ class IcebergSparkSessionExtensions extends 
(SparkSessionExtensions => Unit) {
     // TODO: PullupCorrelatedPredicates should handle row-level operations
     extensions.injectOptimizerRule { _ => 
PullupCorrelatedPredicatesInRowLevelOperations }
     extensions.injectOptimizerRule { _ => RewriteDelete }
+    extensions.injectOptimizerRule { _ => RewriteMergeInto }

Review comment:
       @dilipbiswal, do we have to add MERGE operations to 
`PullupCorrelatedPredicatesInRowLevelOperations`? Could you test the current 
implementation with subqueries inside the merge as well as matched/not matched 
conditions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to