uros-b opened a new pull request, #18136:
URL: https://github.com/apache/iceberg/pull/18136
`PageIterator.initDataReader` carries a commented-out block just after the
values reader is initialized:
```java
// if (dataEncoding.usesDictionary() && converter.hasDictionarySupport())
{
// bindToDictionary(dictionary);
// } else {
// bind(path.getType());
// }
```
The referenced `bindToDictionary(...)` and `bind(...)` methods don't exist
on `PageIterator` or its `BasePageIterator` superclass, so this is leftover
dead code with no live counterpart — dictionary handling is already done just
above via `getDictionaryBasedValuesReader` / `getValuesReader`. This removes it.
No behavior change. The meaningful `TODO` a few lines above is left
untouched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
