sungwy commented on code in PR #18110:
URL: https://github.com/apache/iceberg/pull/18110#discussion_r4028947438
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -162,6 +169,32 @@ public OutputFile newOutputFile(String path) {
return S3OutputFile.fromLocation(path, clientForStoragePath(path),
metrics);
}
+ @Override
+ public Map<String, URI> preSign(Collection<String> paths) {
Review Comment:
Sounds good. The consequence for FILE governance is that whatever API takes
native storage locations and pre-signs them for use or sharing is responsible
for spelling them into the canonical http form.
Because the canonicalized form has a dependency on region (at least for S3)
I think the hop would be FILE API -> S3FileIO (region-aware) -> HttpFile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
