rdblue commented on a change in pull request #2048:
URL: https://github.com/apache/iceberg/pull/2048#discussion_r558642305
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -110,6 +110,11 @@ static TableMetadata newTableMetadata(Schema schema,
int freshSortOrderId = sortOrder.isUnsorted() ? sortOrder.orderId() :
INITIAL_SORT_ORDER_ID;
SortOrder freshSortOrder = freshSortOrder(freshSortOrderId, freshSchema,
sortOrder);
+ // Validate the metrics configuration. Note: we only do this on new tables
to we don't
+ // break existing tables.
+ MetricsConfig.fromProperties(properties).validateReferencedColumns(schema);
+
+
Review comment:
Nit: double newline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
