rambleraptor opened a new pull request, #3241: URL: https://github.com/apache/iceberg-rust/pull/3241
There's some assorted places that we need to raise errors instead of panicking. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #3240. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> This changes a handful of Python functions to return PyResult, which allows us to propagate errors up. It also changes the type signature of `PyManifest.partitions()` to allow None. Neither of these breaks the current type signatures, although the `partitions()` change may result in a Python loop throwing an error. ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Included unit tests. Pretty basic test plan: - Make sure that read_manifest_entries throws an error when given bad input - Make sure that read_manifest_list throws an error when given bad input - Make sure that .partitions() can successfully return None ## AI Disclosure <!-- https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions --> Claude built this PR out under my supervision. I've been doing a lot of Rust investigation as part of my work on PyIceberg. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
