zhjwpku commented on code in PR #936: URL: https://github.com/apache/iceberg-cpp/pull/936#discussion_r4032441938
########## example/CMakeLists.txt: ########## @@ -20,13 +20,65 @@ cmake_minimum_required(VERSION 3.25) project(example) -set(CMAKE_CXX_STANDARD 23) Review Comment: Can we make C++23 still as default and let it accept user supplied option so that C++20 can be test manually locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
