ggershinsky commented on code in PR #17533:
URL: https://github.com/apache/iceberg/pull/17533#discussion_r4034484841
##########
format/spec.md:
##########
@@ -1216,7 +1214,8 @@ Statistics files metadata within `statistics` table
metadata field is a struct w
| _required_ | _required_ | **`statistics-path`** | `string`
| Path of the statistics file. See [Puffin file
format](puffin-spec.md). |
| _required_ | _required_ | **`file-size-in-bytes`** | `long`
| Size of the statistics file. |
| _required_ | _required_ | **`file-footer-size-in-bytes`** | `long`
| Total size of the statistics file's footer (not the footer payload
size). See [Puffin file format](puffin-spec.md) for footer definition. |
- | _optional_ | _optional_ | **`key-metadata`** |
| Base64-encoded implementation-specific key metadata for encryption. |
+ | _optional_ | _optional_ | **`key-metadata`** | `string`
| Base64-encoded implementation-specific key metadata for encryption.
(**Deprecated**: use `key-id` instead) |
Review Comment:
for manifest lists, we did the following:
https://github.com/apache/iceberg/pull/12162
https://github.com/apache/iceberg/pull/12927
An "encrypted key metadata" is a 4-field record (key-id,
encrypted-key-metadata, encrypted-by-id, properties map). All of these records
are kept in the TableMetadata.encryption-keys list. Some of them are reusable
(key encryption keys), but most of them are specific to manifest files. Each
snapshot object keeps the key-id of the "encrypted key metadata" of its
manifest list file.
The situation with stats files looks similar (if not identical) to the
manifest list files. A straightforward technical approach would be to do the
same: write a 4-field "encrypted key metadata" record in the
TableMetadata.encryption-keys list, and add pointer to the record (`key-id`) to
the stats file object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
