nssalian commented on code in PR #9:
URL:
https://github.com/apache/iceberg-verification/pull/9#discussion_r4039508576
##########
table-spec/types/geospatial/cases.json:
##########
@@ -0,0 +1,83 @@
+{
+ "cases": [
+ {
+ "id": "geometry-crs84",
+ "valid": true,
+ "input": "geometry(OGC:CRS84)",
+ "decoded": {"type": "geometry", "crs": "OGC:CRS84"},
+ "clause": "geometry(C) with explicit CRS; the canonical serialized form
is unquoted \"geometry(<C>)\"",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geometry-srid",
+ "valid": true,
+ "input": "geometry(srid:4326)",
+ "decoded": {"type": "geometry", "crs": "srid:4326"},
+ "clause": "geometry(C) example from Appendix C is the unquoted
\"geometry(srid:4326)\"",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geometry-default-crs",
+ "valid": true,
+ "input": "geometry",
+ "decoded": {"type": "geometry", "crs": "OGC:CRS84"},
+ "clause": "geometry(C): if C is not specified, C is OGC:CRS84",
+ "spec_ref": "format/spec.md#primitive-types"
+ },
+ {
+ "id": "geography-crs84-spherical",
+ "valid": true,
+ "input": "geography(OGC:CRS84, spherical)",
+ "decoded": {"type": "geography", "crs": "OGC:CRS84", "algorithm":
"spherical"},
+ "clause": "geography(C, A); the canonical serialized form is unquoted
\"geography(<C>, <A>)\"",
+ "spec_ref": "format/spec.md#appendix-c-json-serialization"
+ },
+ {
+ "id": "geography-default",
+ "valid": true,
+ "input": "geography",
+ "decoded": {"type": "geography", "crs": "OGC:CRS84", "algorithm":
"spherical"},
+ "clause": "geography(C, A): if not specified, C is OGC:CRS84 and A is
spherical",
Review Comment:
re geography(OGC:CRS84): the spec does not pin it though. Looking at
(Appendix C canonical requires (C, A); a CRS-only form is unspecified), so
encoding a MUST accept or MUST reject would over-specify beyond the spec. Left
out deliberately, we can revisit if the spec clarifies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
