sungwy commented on code in PR #18080:
URL: https://github.com/apache/iceberg/pull/18080#discussion_r4040124519
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1410,12 +1400,35 @@ paths:
- $ref: '#/components/parameters/prefix'
- $ref: '#/components/parameters/namespace'
- $ref: '#/components/parameters/table'
+ - $ref: '#/components/parameters/data-access'
post:
tags:
- Catalog API
summary: Remotely signs requests to object storage
operationId: signRequest
+ description: >
+ Signs one request to object storage on the client's behalf.
+
+
+ `RemoteSignResult` takes one of two forms. With `remote-signing`,
`uri` is the
+ requested URI and `headers` carries the signature. With
`presigned-urls`, `uri`
+ carries the signature and `headers` is empty.
Review Comment:
@danielcweeks I thought about this more, and I also see use cases where we
may want to keep the headers in the response when using presigned URL with
FILE:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/using-presigned-url.html
```
Q: Why am I getting an AccessDenied error with HeadersNotSigned: if-range?
When Range is included in X-Amz-SignedHeaders, Amazon S3 requires that
If-Range also be signed if present in the request. Add If-Range to
X-Amz-SignedHeaders when you generate the presigned URL.
```
If a FILE value has an offset, I think we want to keep the protocol open to
being able to support presigned urls that are bound to a `Range`. I agree fully
that keeping the spec generalized in the current form across both modes makes
sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
