szehon-ho commented on PR #18153: URL: https://github.com/apache/iceberg/pull/18153#issuecomment-5719284670
Thanks for looking into the duplicate execution. I don’t think these tests are actually parameterized. `setupPartitionedTable(2)` only controls the table’s format version; it does not affect how many times JUnit invokes the test. These three methods use `@Test`, while `ParameterizedTestExtension` creates per-format-version invocations and injects `formatVersion` only for `@TestTemplate` methods. Each of these tests therefore runs once per test class. With the current change, `formatVersion` is never injected and remains the default value `0`, so `assumeThat(formatVersion).isEqualTo(2)` skips all three tests. The core CI log confirms one invocation of each, all marked `SKIPPED`. I think the existing `setupPartitionedTable(2)` approach is the right one here. Could we revert the test changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
