badalprasadsingh opened a new pull request, #2017: URL: https://github.com/apache/iceberg-go/pull/2017
After my PR #2004 got merged into `main`, the CI failed because of a flaky test. Not something my code-level changes touched :) Raising this PR to fix the flaky `TestWaitForPlanBoundsSlowServerSideCancel`. Check this [failed run](https://github.com/apache/iceberg-go/actions/runs/35150493962) (pasting the failure below): ```text wait_for_plan_test.go:458: Error Trace: /Users/runner/work/iceberg-go/iceberg-go/catalog/rest/wait_for_plan_test.go:458 Error: Condition never satisfied Test: TestWaitForPlanBoundsSlowServerSideCancel Messages: expected the server-side cancel to be attempted --- FAIL: TestWaitForPlanBoundsSlowServerSideCancel (1.18s) ``` Actually, `CancelGracePeriod` also covers delivering the cancel `DELETE`. At `100ms`, loaded -race runners dropped it before the handler ran. Raising grace to 1s here and in `TestPlanFakeWaitCancellationBoundsStalledCleanup`, and the select timeout to `10s` so it stays above the grace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
