ajreid21 commented on code in PR #17713:
URL: https://github.com/apache/iceberg/pull/17713#discussion_r4038672083
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/channel/TestChannel.java:
##########
@@ -55,7 +55,7 @@ public void
controlTopicOffsetsTrackTheHighestPositionConsumed() {
consume(channel, 1, 2);
assertThat(channel.controlTopicOffsets()).isEqualTo(ImmutableMap.of(0,
5L));
- assertThat(channel.received()).hasSize(7);
+ assertThat(channel.received()).hasSize(5);
Review Comment:
This assert -- hasSize(7) -- came from recently merged PR #17933, which only
prevented offset regression while still delivering replayed events. This PR
skips already processed ones (offsets 1-2) so not the received is only 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
