szlta commented on code in PR #18081:
URL: https://github.com/apache/iceberg/pull/18081#discussion_r4046400454
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1276,6 +1307,27 @@ private FileIO tableFileIO(
return newFileIO(context, fullConf.buildKeepingLast(), storageCredentials);
}
+ private boolean useClientSideStorageAccessForEncryptedTable(TableMetadata
tableMetadata) {
+ return useClientSideStorageAccessForEncryptedTables()
+ && tableMetadata != null
+ &&
tableMetadata.properties().containsKey(TableProperties.ENCRYPTION_TABLE_KEY);
+ }
+
+ private void validateNoServerSideStorageAccess(
Review Comment:
I'd argue against that - "X-Iceberg-Access-delegation : vended-creds" is
only part of the spec change proposal at this time - I'm not sure it makes
sense for the code to express uncommitted spec details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
