Revanth14 opened a new pull request, #2024: URL: https://github.com/apache/iceberg-go/pull/2024
## Summary `ADLSManagedIdentityEnabled` has no counterpart in the Java or PyIceberg implementations, and `ADLSClientID` collides with a PyIceberg key of the same name that means something different — there it is a service principal client ID used with `adls.client-secret` and `adls.tenant-id`, neither of which this implementation defines. Here the key is only ever read as a user assigned managed identity ID, and only when `adls.auth.managed-identity.enabled` is `"true"`. This documents both, and moves `ADLSClientID` next to `ADLSManagedIdentityEnabled` so the two coupled properties sit together and the surrounding constants keep their gofmt alignment. Raised by @laskoviymishka in review on #2018. ## Validation - `gofmt`, `gofumpt`, `go vet ./io/...`, `go build ./...` — clean. - `go test ./io/... -count=1 -race` — passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
