jopdorp commented on PR #2367: URL: https://github.com/apache/iceberg-rust/pull/2367#issuecomment-5732200998
We're building on iceberg-rust with a Lakekeeper catalog and need delete files to land in a snapshot through the transaction API, so I looked at where this stands. The blocking comment is about direction, and reading the code I think it's right: without validation against concurrent commits the removal paths can't be used safely, and nothing uses them yet. #3046 takes the composition route from #2620 and already adds and removes data files under one snapshot with the validations in the producer. We're contributing the review fixes there and will add the row-delta action on top of it afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
