jopdorp commented on PR #3046: URL: https://github.com/apache/iceberg-rust/pull/3046#issuecomment-5733128922
We need compaction and, on top of this producer, a row-delta action for a service we build on iceberg-rust with a Lakekeeper catalog, so I worked through the review and did the fixes on top of your branch: hotcache/iceberg-rust#1. One commit per point from @rexminnis and the V2 tests @JanKaul asked for, each with a test that fails on the current code. One choice to flag: the manifest counter lives on the action rather than the producer, because the producer is rebuilt on every commit attempt and the action is what survives a retry. Happy to adjust anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
