csringhofer commented on code in PR #17112:
URL: https://github.com/apache/iceberg/pull/17112#discussion_r4048580276
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -166,6 +166,8 @@ private static String convertToTypeString(Type type) {
return "timestamp";
case FIXED:
case BINARY:
+ case GEOMETRY:
Review Comment:
I did test with recent HMS, and Trino.
Impala tests's work when unknown is used, including storing column stats in
HMS.
Trino couldn't read the table though, both DESCRIBE and SELECT failed with
"java.lang.RuntimeException: Internal error parsing position 0 of 'unknown'"
https://gerrit.cloudera.org/#/c/24536/10/testdata/workloads/functional-query/queries/QueryTest/iceberg-trino-interop-geometry.test
I tested with Trino 482 and 483 (latest version at the moment).
On one side I think that this is mainly a Trino issue and they should fix
"unknown" handling in HMS backed Iceberg tables, on the other side I would
better avoid this interop issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
