M-Tesla commented on PR #3144: URL: https://github.com/apache/iceberg-rust/pull/3144#issuecomment-5736446968
Thank you for coming back to this, @laskoviymishka. I merged current main (no rebase) so the branch builds again after #3214. `visit_in` now passes `reference.field().field_type.as_ref()` into both `bytes_to_datum` calls, so the `field_type` local and the clones are gone. I also took the non-blocking notes: the missing-lower-bound comment sits next to the manifest guard, `finite_bound` now calls out the Java/PyIceberg divergence, and there is a companion might-match test (NaN lower, upper = 3.0, `IN (2.0, 4.0)`). On giving `StrictMetricsEvaluator::not_in` the same `finite_bound` treatment: I would keep that as a follow-up. Strict staying conservative is the right default until we pin it the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
