rdblue opened a new pull request, #18171: URL: https://github.com/apache/iceberg/pull/18171
This implements inheritance in `V4ManifestReader`. This does not handle `first_row_id` assignment, which will be in a separate PR. v3 and earlier user `InheritableMetadataFactory` to set up inheritance that sets spec ID, snapshot ID, sequence number, and manifest location. This PR ensures the same fields are set: - Spec ID is written with v4 data files, so it is out of scope - Snapshot ID is inherited using `TrackingStruct#inherit(long, long)` - Sequence number is also inherited by calling `TrackingStruct#inherit(long, long)` - Manifest location is set by projecting `_file`, similar to how `_pos` is projected through readers This removes `inheritFrom(Tracking)` and `setManifestLocation`. The first inheritance method didn't accept `ManifestFile` and is now simpler. It doesn't need to check manifest tracking fields consistency. `setManifestLocation` is not needed by using readers to set the `_file` field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
