fallintoplace opened a new pull request, #2028: URL: https://github.com/apache/iceberg-go/pull/2028
## What Avoid the extra schema walk when looking up cached file filter plans. ## Why The key writer already handles nested fields recursively. `iceberg.Visit` then walks the same fields again, including on cache hits. ## Implementation - Encode the top-level fields from `FieldsRef` with the existing recursive writer. - Remove the no-op visitor and keep invalid-schema errors. ## Benchmark Repeated cache hits on Apple M1 Pro, Go 1.26.3. Before/after builds use the same benchmarks, with 10 runs each. | Schema | B/op before → after | Allocs/op before → after | | --- | ---: | ---: | | Existing filter setup | 1,064 → 1,016 | 8 → 7 | | Flat, 10 fields | 552 → 504 | 7 → 6 | | Nested, depth 3 | 168 → 120 | 5 → 4 | | Nested, depth 8 | 552 → 504 | 7 → 6 | | Wide struct, 100 fields | 8,488 → 8,440 | 12 → 11 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
