ghoshp83 commented on PR #3999: URL: https://github.com/apache/iceberg-python/pull/3999#issuecomment-5742417218
Closing this in favour of #3976, which was opened two days earlier and covers both halves of #3970 — the `commit_table` session mutation that this PR fixed, and the cached `S3FileSystem` signer that it did not. I missed #3976 when I checked for existing work: it links the issue from its body rather than its title, and it never commented on #3970, so my scan of issue comments and PR titles came up empty. That is my error, not a problem with the PR. No objection to #3976's approach — applying the table token through a request-local auth callable is the more complete fix, since `Session.auth` overwrites a per-request `Authorization` header and the plain header assignment never reached the wire. My note on #3970 about that behaviour still stands as background for anyone reviewing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
