huaxingao commented on code in PR #18070:
URL: https://github.com/apache/iceberg/pull/18070#discussion_r4055191002
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -164,6 +169,18 @@ public HTTPClient withAuthSession(AuthSession session) {
return new HTTPClient(this, session);
}
+ private static Duration parseKeyLifetime(String lifetime) {
+ if (lifetime == null) {
+ return null;
+ }
+ try {
+ return Duration.parse(lifetime);
Review Comment:
Should we also reject zero and negative values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
