zhjwpku commented on code in PR #774:
URL: https://github.com/apache/iceberg-cpp/pull/774#discussion_r4057237045
##########
src/iceberg/update/pending_update.cc:
##########
@@ -35,6 +35,10 @@ Status PendingUpdate::Commit() {
if (!ctx_->transaction) {
// Table-created path: no transaction exists yet, create a temporary one.
ICEBERG_ASSIGN_OR_RAISE(auto txn, Transaction::Make(ctx_));
+ auto self = weak_from_this().lock();
+ if (self) {
+ ICEBERG_RETURN_UNEXPECTED(txn->AddUpdate(self));
+ }
Review Comment:
Standalone update lifecycle issue has been resolved in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
