kbendick commented on a change in pull request #2081:
URL: https://github.com/apache/iceberg/pull/2081#discussion_r558827492
##########
File path:
spark3/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##########
@@ -529,7 +529,7 @@ private Table buildPartitionedTable(String desc,
PartitionSpec spec, String udf,
return Lists.newArrayList(
record(schema, 0L, parse("2017-12-22T09:20:44.294658+00:00"),
"junction"),
record(schema, 1L, parse("2017-12-22T07:15:34.582910+00:00"),
"alligator"),
- record(schema, 2L, parse("2017-12-22T06:02:09.243857+00:00"),
"forrest"),
+ record(schema, 2L, parse("2017-12-22T06:02:09.243857+00:00"), ""),
Review comment:
I added a test that does not change any of the exising test data or add
a new file at all, in `TestInclusiveMetricsEvaluator`.
https://github.com/apache/iceberg/pull/2081/files#diff-a107d871a1a5d5c4029451db68cf5497ddc9432d90619e263270cf72c3536c23R73
I personally prefer changing the input data on the larger end to end test
that covers many portions (`TestFilteredScan`) as they truly cover the
situation where the bug was originally reported occurring (and where it is
likely to happen based on usages of `truncateBinary`) - filtered scans with
empty row data.
But I've added another possible way to test the reported scenario
-`TestInclusiveMetricsEvaluator`.
If you'd like me to add a standalone spark test or something, let me know.
Or if you prefer the new test, let me know and I can revert the change to the
input records of the other test suite.
Thanks for your review @rdblue 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
