akashchamp commented on PR #3951: URL: https://github.com/apache/iceberg-python/pull/3951#issuecomment-5750824404
Thanks for the review and for tracking down the other two loaders. I added the same base-class check to `_import_catalog` in `pyiceberg/catalog/__init__.py` (`py-catalog-impl` must be a `Catalog` subclass) and to `AuthManagerFactory.create` in `pyiceberg/catalog/rest/auth.py` (`auth.impl` must be an `AuthManager` subclass), each raising a clear `ValueError` before anything is instantiated. Regression tests for both are in `tests/catalog/test_base.py`, `tests/catalog/test_rest.py`, and `tests/catalog/test_rest_auth.py`, and the existing custom `SqlCatalog` and `BasicAuthManager` tests confirm valid implementations still load. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
