huaxingao commented on PR #18195: URL: https://github.com/apache/iceberg/pull/18195#issuecomment-5764484486
The change makes sense to me. Two nits: 1. Please mention the migration in the title. Something like "Build: Bump AWS SDK to 2.54.17 and migrate to Apache HttpClient 5". 2. `aws-bundle/LICENSE` still says we bundle Commons Codec and Commons Logging (around lines 206 and 213). This PR drops both from the jar, so those two blocks should be removed. Also worth a release note: Apache 5 uses different logger names, so `org.apache.http.*` logging configs will stop matching. `http-client.type=apache` still works, but it now builds `Apache5HttpClient`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
