rambleraptor commented on code in PR #3991:
URL: https://github.com/apache/iceberg-python/pull/3991#discussion_r4067827533
##########
pyiceberg/manifest.py:
##########
@@ -969,16 +973,16 @@ def clear(self) -> None:
if self._cache is not None:
self._cache.clear()
- def get_or_cache(self, manifest_file: ManifestFile) -> ManifestFile:
- if self._cache is None:
+ def get_or_cache(self, manifest_file: ManifestFile, table_uuid: uuid.UUID
| None = None) -> ManifestFile:
+ if self._cache is None or table_uuid is None:
Review Comment:
I don't think we should bail out if table_uuid is None. That means that
places where we forgot to plumb through the UUID will lose their caching.
The proper thing is just to use the old-style cache keys. That way, it's the
same behavior as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
