viirya commented on code in PR #2635: URL: https://github.com/apache/iceberg-rust/pull/2635#discussion_r4074034057
########## crates/iceberg/src/arrow/record_batch_transformer.rs: ########## Review Comment: Agreed — silently replacing an unsupported default with NULL could return incorrect data. Applied your suggested match in fbc8f72b: absent optional fields without a default still get typed NULLs, primitive defaults retain their existing behavior, and non-primitive defaults return `FeatureUnsupported` with the field name and type. Added regression coverage for both optional and required structs with an initial default. The TODO now tracks implementing complex defaults, including child defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
