twthorn commented on code in PR #18082:
URL: https://github.com/apache/iceberg/pull/18082#discussion_r4074945820
##########
kafka-connect/kafka-connect-transforms/src/test/java/org/apache/iceberg/connect/transforms/TestDebeziumTransform.java:
##########
@@ -60,11 +60,11 @@ public class TestDebeziumTransform {
.build();
@Test
- public void testDmsTransformNull() {
- try (DmsTransform<SinkRecord> smt = new DmsTransform<>()) {
+ public void testDebeziumTransformNull() {
+ try (DebeziumTransform<SinkRecord> smt = new DebeziumTransform<>()) {
SinkRecord record = new SinkRecord("topic", 0, null, null, null, null,
0);
Review Comment:
As mentioned in Debezium
[docs](https://debezium.io/documentation/reference/stable/transformations/applying-transformations-selectively.html)
> A tombstone event that has the same key, but a null value
So I'd suggest setting key non-null, and value null. The test should still
pass and this more accurately mirrors Debezium's tombstone behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
