rdblue commented on PR #18200: URL: https://github.com/apache/iceberg/pull/18200#issuecomment-5804813807
The changes here look correct since this is currently a very simple change. It just moves code into a different class. But what I was hoping was to do a bit more work and define a validator API. What should that API look like? Should it pass TableMetadata to validate or a current snapshot ID or should it be configured to know the target ref? Is there anything specific to v3 in the API that we need to change or will everything work fine in v4? If you've already thought through these things and the API is good as-is, then I think it would be good to see that in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
