smaheshwar-pltr commented on code in PR #18247: URL: https://github.com/apache/iceberg/pull/18247#discussion_r4097451031
########## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOLegacyMd5.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.aws.s3; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.mockserver.integration.ClientAndServer.startClientAndServer; +import static org.mockserver.model.HttpRequest.request; +import static org.mockserver.model.HttpResponse.response; + +import java.security.MessageDigest; +import java.util.Base64; +import java.util.List; +import java.util.Map; +import org.apache.iceberg.aws.AwsClientProperties; +import org.apache.iceberg.io.BulkDeletionFailureException; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.mockserver.integration.ClientAndServer; +import org.mockserver.model.HttpRequest; + +class TestS3FileIOLegacyMd5 { Review Comment: This preserves coverage from the old legacy-MinIO fixture https://github.com/apache/iceberg/blob/3957d26daa535eb5f03e101f1210ee234e978f9a/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOWithLegacyMinIO.java#L24-L35 That server explicitly rejects bulk deletes without Content-MD5, and Iceberg still supports this compatibility option for older stores: https://github.com/apache/iceberg/blob/3957d26daa535eb5f03e101f1210ee234e978f9a/aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java#L86-L92 So to keep that coverage, this is a local HTTP fixture that enforces that legacy requirement to test the `S3FileIO` with the option enabled and disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
