danielcweeks commented on code in PR #18166: URL: https://github.com/apache/iceberg/pull/18166#discussion_r4109238802
########## AGENTS.md: ########## @@ -137,6 +137,13 @@ The `api/` module has the strongest stability guarantees — breaking changes ar ### Testing +**Write the test plan before the tests.** State in the PR description what behavior needs verifying and why each case matters — a few lines, not a document. + +- Test the behavior in the plan. Coverage is not a target. +- Test the behavior this change adds or modifies. Don't assert the correctness of components this code merely calls. +- One behavior per test method. No omnibus tests asserting several unrelated things. +- Don't add a test whose failure would not indicate a user-visible regression. Review Comment: I'm not sure I understand the meaning of this line. What does "user-visible" mean in this context. A regression that goes unnoticed doesn't sound good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
