PingLiuPing commented on code in PR #936: URL: https://github.com/apache/iceberg-cpp/pull/936#discussion_r4119237546
########## example/CMakeLists.txt: ########## @@ -20,13 +20,79 @@ cmake_minimum_required(VERSION 3.25) project(example) -set(CMAKE_CXX_STANDARD 23) +# C++20 is the minimum standard iceberg-cpp's public headers support, so the +# example builds as C++20 by default to keep that contract exercised. Set this to +# 23 to also check the headers from a C++23 consumer. +set(ICEBERG_EXAMPLE_CXX_STANDARD + 20 + CACHE STRING "C++ standard used to build the example (20 or 23)") +set_property(CACHE ICEBERG_EXAMPLE_CXX_STANDARD PROPERTY STRINGS 20 23) +if(NOT ICEBERG_EXAMPLE_CXX_STANDARD MATCHES "^(20|23)$") + message(FATAL_ERROR "ICEBERG_EXAMPLE_CXX_STANDARD must be 20 or 23, got " Review Comment: Thanks, changed to `if(ICEBERG_EXAMPLE_CXX_STANDARD MATCHES "^(98|11|14|17)$")` to keep compatitable with future c++ standard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
