mbutrovich commented on code in PR #3241:
URL: https://github.com/apache/iceberg-rust/pull/3241#discussion_r4126282243
##########
bindings/python/src/manifest.rs:
##########
@@ -221,10 +220,10 @@ impl PyManifestList {
}
#[pyfunction]
-pub fn read_manifest_list(bs: &[u8]) -> PyManifestList {
- PyManifestList {
- inner: ManifestList::parse_with_version(bs,
FormatVersion::V2).unwrap(),
- }
+pub fn read_manifest_list(bs: &[u8]) -> PyResult<PyManifestList> {
+ Ok(PyManifestList {
+ inner: ManifestList::parse_with_version(bs,
FormatVersion::V2).map_err(to_py_err)?,
Review Comment:
> we might want to follow up and parameterize this one
#3262 tracks this under Task 3, so the follow-up already has an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
