huaxingao commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r4128743265
########## format/spec.md: ########## @@ -1913,6 +1916,12 @@ Reading v4 metadata: * Relative paths must be resolved against the table location before use (see [Path Resolution](#path-resolution)) * When `location` is omitted, the table location must be provided (see [Table Location Specification](#table-location-specification)) +Equality deletes are prohibited in v4. + +* Writers must not add equality delete files to v4 tables; equality deletes cannot be added as an entry to a v4 manifest +* Upgrading a v2 or v3 table to v4 does not require rewriting data or delete files Review Comment: @rdblue Your wording is clearer than what's here, I'll pick it up in the follow-up. ########## format/spec.md: ########## @@ -113,7 +114,7 @@ There are two types of row-level deletes: * **Position deletes** -- Mark a row deleted by data file path and the row position in the data file. Position deletes are encoded in a [_position delete file_](#position-delete-files) (V2) or [_deletion vector_](#deletion-vectors) (V3 or above). -* **Equality deletes** -- Mark a row deleted by one or more column values, like id = 5. Equality deletes are encoded in [_equality delete file_](#equality-delete-files). +* **Equality deletes** -- Mark a row deleted by one or more column values, like id = 5. Equality deletes are encoded in [_equality delete file_](#equality-delete-files) (may be created in v2 and v3 tables only). Review Comment: Agreed, the "two types" framing doesn't hold anymore. I'll restructure this in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
