manuzhang commented on code in PR #18269:
URL: https://github.com/apache/iceberg/pull/18269#discussion_r4131170217
##########
core/src/test/java/org/apache/iceberg/TestStatsUtil.java:
##########
@@ -541,7 +541,7 @@ public void testContentStatsWriteSchemaNestedStruct() {
Map<String, String> properties =
ImmutableMap.of(TableProperties.METRICS_MODE_COLUMN_CONF_PREFIX +
"id", "none");
Types.StructType actual =
- StatsUtil.statsWriteSchema(schema, MetricsConfig.from(properties,
schema, null));
+ StatsUtil.statsWriteSchema(schema, MetricsTestUtil.from(properties,
schema));
Review Comment:
The nuance is the order change only happens with JDK 21, which is excluded
from PR CI. That's why the test only fails on main branch.
<img width="2114" height="1198" alt="image"
src="https://github.com/user-attachments/assets/36167f4a-2136-440a-9237-ceef54dee505";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
