rdblue commented on a change in pull request #2054:
URL: https://github.com/apache/iceberg/pull/2054#discussion_r559745902
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -129,10 +130,12 @@ public ObjectInspector getObjectInspector() {
* it adds the previousException as a root cause.
* @param serDeProperties The source of the hive schema
* @param previousException If we had an exception previously
+ * @param autoConversion If <code>true</code> then autoConversion of the
schema is enabled
Review comment:
Since the argument name is `autoConversion`, the doc doesn't add much
value. What about clarifying what it means? Like "When true, convert
unsupported types to more permissive ones, like tinyint to int"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
