kamcheungting-db commented on PR #939: URL: https://github.com/apache/iceberg-cpp/pull/939#issuecomment-5907123302
I split the original change into a reviewable stack: 1. #974 — mechanical `DataFile` serde move into core 2. #975 — Java-compatible `DataFile` JSON 3. **#939 — core `FileScanTask` serde and split validation** 4. #940 — strict schema and partition ID parsing For the incremental diff that belongs only to this PR, use: https://github.com/kamcheungting-db/iceberg-cpp/compare/datafile-serde-java...filescan-task-serde The key distinction in this layer is: - Core task JSON is self-contained and uses inline `"delete-files": [...]`. - REST may use response-local `"delete-file-references": [0]`, which remains REST-only. - For a 100-byte file, only `start = 0` and `length = 100` are accepted; a split such as `start = 10` is rejected instead of silently becoming a whole-file task. The PR description now includes a complete JSON example and the stack order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
