nastra commented on code in PR #18249:
URL: https://github.com/apache/iceberg/pull/18249#discussion_r4143310651
##########
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMock.java:
##########
@@ -42,25 +42,23 @@ public class AliyunOSSMock {
static final String PROP_ROOT_DIR = "root-dir";
static final String ROOT_DIR_DEFAULT = "/tmp";
- static final String PROP_HTTP_PORT = "server.port";
Review Comment:
I'm not sure if external consumer projects might still actually configure
the port via properties, so maybe we should still respect it when it's set and
only fallback to 0 when not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
