KaiqiJinWow commented on PR #3478: URL: https://github.com/apache/iceberg-python/pull/3478#issuecomment-5915881561
> Can you add an integration test for this with Spark? I'd really love to see that we can successfully read a deletion vector written by an outside source. > > Even copying in a fixture made by somebody else would be great. Thanks @rambleraptor! I added two externally generated `.bin` fixtures in e71c8d14: one containing a single DV and another containing six DVs sharing the same physical file. The tests verify the expected deleted row positions using the manifest-provided content ranges. The packed fixture test also checks that all six DVs survive deduplication and are associated with the correct data files. Could you take another look when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
