laskoviymishka opened a new pull request, #2080: URL: https://github.com/apache/iceberg-go/pull/2080
unlink testify from the library MockFS, MockFSReadFile and MockFile lived in internal/mock_fs.go, a non-test file in package internal that imports github.com/stretchr/testify/mock. Because the root iceberg package imports internal, every consumer that used iceberg-go only for its types linked testify (and its objx and yaml deps) into their production binary. Move the mocks to a dedicated internal/iomock package that only _test.go files import. The root iceberg package's dependency closure loses testify, objx and go.yaml.in/yaml/v3: for a types-only consumer that is 7 fewer packages and 3 fewer modules, with no test framework linked into production. testify remains a test dependency of the module. No production code referenced these mocks; only test files did, and they now import internal/iomock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
