rambleraptor commented on code in PR #2076:
URL: https://github.com/apache/iceberg-go/pull/2076#discussion_r4149222592
##########
schema.go:
##########
@@ -1555,6 +1569,13 @@ func (s *setFreshIDs) Variant(v VariantType) Type {
// fields in it. The nextID function is used to iteratively generate the ids,
if
// it is nil then a simple incrementing counter is used starting at 1.
func AssignFreshSchemaIDs(sc *Schema, nextID func() int) (*Schema, error) {
+ return AssignFreshSchemaIDsWithBase(sc, nil, nextID)
+}
+
+// AssignFreshSchemaIDsWithBase is like AssignFreshSchemaIDs, but fields whose
Review Comment:
Yeah, sounds good. Did the comment and guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
