comphead commented on code in PR #3303:
URL: https://github.com/apache/iceberg-rust/pull/3303#discussion_r4150500107
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -1200,53 +1200,57 @@ impl MetadataStripVisitor {
field_stack: Vec::new(),
}
}
+
+ /// Stores a field's name and nullability, to rebuild it once its type has
+ /// been visited.
+ fn push_field(&mut self, field: &FieldRef) -> Result<()> {
Review Comment:
maybe we can come up with more domain specific names, rather than `push`,
`pop`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
