pvary commented on code in PR #17900:
URL: https://github.com/apache/iceberg/pull/17900#discussion_r4154871944
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/CompareSchemasVisitor.java:
##########
@@ -181,6 +181,20 @@ public Result primitive(Type.PrimitiveType primitive,
Integer tableSchemaId) {
}
}
+ @Override
+ public Result variant(Types.VariantType variant, Integer tableSchemaId) {
+ if (tableSchemaId == null) {
+ return Result.SCHEMA_UPDATE_NEEDED;
+ }
+
+ Type tableSchemaType = tableSchema.findField(tableSchemaId).type();
+ if (tableSchemaType.isVariantType()) {
+ return Result.SAME;
+ }
+
+ return Result.SCHEMA_UPDATE_NEEDED;
Review Comment:
nit: maybe in an `else`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
