nastra commented on code in PR #17872:
URL: https://github.com/apache/iceberg/pull/17872#discussion_r4155486948
##########
delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java:
##########
@@ -448,13 +447,13 @@ private void tagCurrentSnapshot(long deltaVersion,
Transaction transaction) {
* (either absolute or relative)
* @param tableRoot the root path of the delta table
*/
- private static String getFullFilePath(String path, String tableRoot) {
+ static String getFullFilePath(String path, String tableRoot) {
Review Comment:
not sure it's worth making this one package-private for testing. I would
probably just fix this without adding a test like we did for
https://github.com/apache/iceberg/commit/cae7d1bad863082bd5808f93424290706f4c6cc8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
