nastra commented on PR #18310: URL: https://github.com/apache/iceberg/pull/18310#issuecomment-5933522359
> > Given that we just released 1.12.0 this PR isn't a pure rename of avgValueSize() methods to totalBytes() in all of the places anymore. We now actually have to do the changes in a backwards compatible way. I'll set the PR to WIP until I have the correct changes > > those are v4 APIs where nobody should be using. can we just note the breaking change in revapi exclusion? @stevenzwu we can certainly do that if people agree. It is kind of a bad timing for this rename since `avgValueSizes()` was added to a few central places and just released, like `ContentFile`/ `Metrics`/`BaseFile`/`ContentFileParser` and also to the REST spec. Would be good to also hear from others here /cc @rdblue @RussellSpitzer @pvary @amogh-jahagirdar @singhpk234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
