rdblue commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4160118451
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -1548,7 +1619,10 @@ public void
partitionFilterKeepsFileWithUnknownSpec(FileFormat format) throws IO
TrackedFile actual = readOne(builder);
- assertThat(actual).usingComparator(FILE_COMPARATOR).isEqualTo(file);
+ assertThat(actual.location()).isEqualTo(file.location());
+ assertThat(actual.partition())
+ .as("unknown spec's partition cannot be projected to its output type")
+ .isNull();
Review Comment:
Related to the changes above, I think that the file should be skipped by the
filter and returned. That means that `partition()` should throw an exception
that is caught by the filter code. Probably `ValidationException`. This test
should validate that the file is returned and that its `partition()` method
throws the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
