openinx commented on a change in pull request #2064:
URL: https://github.com/apache/iceberg/pull/2064#discussion_r560018080
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -138,6 +138,9 @@ private TableProperties() {
public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+ public static final String WRITE_SHUFFLE_BY_PARTITION =
"write.shuffle-by.partition";
Review comment:
> In the short term, I expect Flink to only support none and partition
modes.
In this first PR, I think it's great to support `none` & `partition` mode.
For unsorted table with `sort` mode, we also had an internal discussion,
using the `DataStream#partitionCustom` (proposed from @stevenzwu ) way should
be OK ; For sorted table, the records sorting is an problem ( for keeping
the same semantics of SortOrder) , I suspect whether there's a real need for
flink to write sorted records ( Could hava more discussion).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
