gkalashyan-akv commented on code in PR #15:
URL:
https://github.com/apache/iceberg-verification/pull/15#discussion_r4165677894
##########
.prettierrc.json:
##########
@@ -0,0 +1,3 @@
+{
+ "printWidth": 120
Review Comment:
[P2] Account for CRLF checkouts in the formatting check
With `core.autocrlf=true` (the setting on this Windows machine), a fresh
checkout converts all six fixture files to CRLF, while this configuration
leaves Prettier's default LF requirement in place. On the unmodified PR head,
`npx --yes [email protected] --check "table-spec/**/*.json"` fails on all six
files; the same command with `--end-of-line auto` passes. Could we pin fixture
line endings with `.gitattributes` (for example, `table-spec/**/*.json text
eol=lf`), or configure Prettier to accept checkout line endings? Otherwise the
new lint target fails on a clean checkout solely because of the contributor's
Git configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
